Re: [PATCH] spi-nor: Remove unused spi-nor.o rule
From: kernel test robot
Date: Sun Jul 26 2020 - 07:52:53 EST
Hi Joel,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Joel-Stanley/spi-nor-Remove-unused-spi-nor-o-rule/20200722-170150
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4fa640dc52302b5e62b01b05c755b055549633ae
config: i386-randconfig-c001-20200726 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
ld: drivers/mtd/spi-nor/controllers/intel-spi.o: in function `intel_spi_probe':
>> drivers/mtd/spi-nor/controllers/intel-spi.c:932: undefined reference to `spi_nor_scan'
vim +932 drivers/mtd/spi-nor/controllers/intel-spi.c
45397787536434 drivers/mtd/spi-nor/intel-spi.c Tudor Ambarus 2019-09-24 896
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 897 struct intel_spi *intel_spi_probe(struct device *dev,
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 898 struct resource *mem, const struct intel_spi_boardinfo *info)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 899 {
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen 2017-04-25 900 const struct spi_nor_hwcaps hwcaps = {
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen 2017-04-25 901 .mask = SNOR_HWCAPS_READ |
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen 2017-04-25 902 SNOR_HWCAPS_READ_FAST |
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen 2017-04-25 903 SNOR_HWCAPS_PP,
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen 2017-04-25 904 };
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 905 struct mtd_partition part;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 906 struct intel_spi *ispi;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 907 int ret;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 908
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 909 if (!info || !mem)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 910 return ERR_PTR(-EINVAL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 911
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 912 ispi = devm_kzalloc(dev, sizeof(*ispi), GFP_KERNEL);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 913 if (!ispi)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 914 return ERR_PTR(-ENOMEM);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 915
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 916 ispi->base = devm_ioremap_resource(dev, mem);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 917 if (IS_ERR(ispi->base))
011de1b1db534b drivers/mtd/spi-nor/intel-spi.c Nicholas Mc Guire 2017-02-13 918 return ERR_CAST(ispi->base);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 919
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 920 ispi->dev = dev;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 921 ispi->info = info;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 922 ispi->writeable = info->writeable;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 923
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 924 ret = intel_spi_init(ispi);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 925 if (ret)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 926 return ERR_PTR(ret);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 927
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 928 ispi->nor.dev = ispi->dev;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 929 ispi->nor.priv = ispi;
45397787536434 drivers/mtd/spi-nor/intel-spi.c Tudor Ambarus 2019-09-24 930 ispi->nor.controller_ops = &intel_spi_controller_ops;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 931
cfc5604c488ccd drivers/mtd/spi-nor/intel-spi.c Cyrille Pitchen 2017-04-25 @932 ret = spi_nor_scan(&ispi->nor, NULL, &hwcaps);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 933 if (ret) {
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 934 dev_info(dev, "failed to locate the chip\n");
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 935 return ERR_PTR(ret);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 936 }
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 937
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 938 intel_spi_fill_partition(ispi, &part);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 939
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 940 /* Prevent writes if not explicitly enabled */
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 941 if (!ispi->writeable || !writeable)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 942 ispi->nor.mtd.flags &= ~MTD_WRITEABLE;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 943
11edc1133e3023 drivers/mtd/spi-nor/intel-spi.c RafaÅ MiÅecki 2018-07-21 944 ret = mtd_device_register(&ispi->nor.mtd, &part, 1);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 945 if (ret)
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 946 return ERR_PTR(ret);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 947
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 948 return ispi;
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 949 }
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 950 EXPORT_SYMBOL_GPL(intel_spi_probe);
8afda8b26d01ee drivers/mtd/spi-nor/intel-spi.c Mika Westerberg 2016-11-28 951
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip