Re: [PATCH] io: Fix return type of _inb and _inl

From: Andy Shevchenko
Date: Sun Jul 26 2020 - 05:00:55 EST


On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne <shorne@xxxxxxxxx> wrote:
>
> The return type of functions _inb, _inw and _inl are all u16 which looks
> wrong. This patch makes them u8, u16 and u32 respectively.
>
> The original commit text for these does not indicate that these should
> be all forced to u16.

Is it in alight with all architectures? that support this interface natively?

(Return value is arch-dependent AFAIU, so it might actually return
16-bit for byte read, but I agree that this is weird for 32-bit value.
I think you have elaborate more in the commit message)

--
With Best Regards,
Andy Shevchenko