Re: Re: checkpatch: support deprecated terms checking

From: SeongJae Park
Date: Sat Jul 25 2020 - 19:56:32 EST


On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Sat, 2020-07-25 at 15:02 +0200, MichaÅ MirosÅaw wrote:
> > Hello,
> >
> > I see that this patch went into next and is already inciting people to
> > do wrong things [1]. Can you please fix it to require '--subjective'
> > switch or otherwise mark it clearly as suggestion-only?
> >
> > The coding-style as in Linus' master says about *NEW* uses of the words
> > listed (those introductions I expect to be actually rare) and not about
> > existing use in the code or industry. Making a noise about all uses
> > found surely will generate a lot more irrelevant patches.
> >
> > [1] https://www.spinics.net/lists/linux-tegra/msg51849.html
>
> And if not reverted, perhaps do not check existing files
> at all but only check patches and change the message to
> show only suggestions not from a specification.

Agreed for this case. However, excluding existing file check doesn't fully
avoid this problem. Also, more terms having different deprecation rules might
be added in future. How about allowing file check but show reference in the
suggestion message as below?

> ---
[...]


Thanks,
SeongJae Park


================================ >8 ===========================================