Re: [PATCH] ipv6: Fix nexthop reference count in ip6_route_info_create()

From: Markus Elfring
Date: Sat Jul 25 2020 - 05:34:52 EST


â
> When ip6_route_info_create() returns, local variable "nh" becomes
> invalid, so the refcount should be decreased to keep refcount balanced.

Can it be helpful to use the term âreference countâ in consistent ways?


> Fix this issue

How do you think about to replace this wording by the tag âFixesâ?


> by pulling up the error source routing handling when
> nexthops can not be used with source routing.

Does the movement of an if statement according to the check of the
data structure member ârt->fib6_src.plenâ in an if branch really help here?

Regards,
Markus