Re: [PATCH 00/40] Set 5: Penultimate set of SCSI related W=1 warnings

[Martin K. Petersen]

On Thu, 23 Jul 2020 13:24:06 +0100, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Hopefully this is the penultimate set.
> 
> Lee Jones (40):
>   scsi: lpfc: lpfc_els: Fix some function parameter descriptions
>   scsi: lpfc: lpfc_hbadisc: Fix kerneldoc parameter
>     formatting/misnaming/missing issues
>   scsi: ufs: ufs-qcom: Demote nonconformant kerneldoc headers
>   scsi: bnx2i: bnx2i_init: Fix parameter misnaming in function header
>   scsi: ufs: ufs-exynos: Make stubs 'static inline'
>   scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header
>   scsi: bfa: bfa_port: Staticify local functions
>   scsi: bnx2i: bnx2i_sysfs: Add missing descriptions for 'attr'
>     parameter
>   scsi: bfa: bfa_fcpim: Remove set but unused variable 'rp'
>   scsi: bfa: bfa_fcpim: Demote seemingly unintentional kerneldoc header
>   scsi: qedi: qedi_main: Remove 2 set but unused variables
>   scsi: ips: Remove some set but unused variables
>   scsi: ips: Convert strnlen() to memcpy() since result should not be
>     NUL terminated
>   scsi: qla4xxx: ql4_83xx: Remove set but unused variable 'status'
>   scsi: lpfc: lpfc_init: Use __printf() format notation
>   scsi: lpfc: lpfc_init: Add and rename a whole bunch of function
>     parameter descriptions
>   scsi: qla4xxx: ql4_bsg: Rename function parameter descriptions
>   scsi: lpfc: lpfc_mbox: Fix a bunch of kerneldoc misdemeanours
>   scsi: lpfc: lpfc_nportdisc: Add description for lpfc_release_rpi()'s
>     'ndlpl param
>   scsi: bfa: bfa_ioc: Remove a few unused variables 'pgoff' and 't'
>   scsi: csiostor: csio_hw: Mark known unused variable as __always_unused
>   scsi: csiostor: csio_hw_t5: Remove 2 unused variables
>     {mc,edc}_bist_status_rdata_reg
>   scsi: bfa: bfa_ioc: Staticify non-external functions
>   scsi: csiostor: csio_rnode: Add missing description for
>     csio_rnode_fwevt_handler()'s 'fwevt' param
>   scsi: bfa: bfa_ioc_ct: Demote non-compliant kerneldoc headers to
>     standard comments
>   scsi: mvsas: mv_init: Place 'core_nr' inside correct clause
>   scsi: bfa: bfa_fcs_rport: Remove unused variable 'adisc'
>   scsi: bnx2i: bnx2i_hwi: Fix a whole host of kerneldoc issues
>   scsi: bnx2i: bnx2i_iscsi: Add, remove and edit some function parameter
>     descriptions
>   scsi: be2iscsi: be_iscsi: Correct misdocumentation of function param
>     'ep'
>   scsi: qedi: qedi_fw: Remove set but unused variable 'tmp'
>   scsi: esas2r: esas2r: Add braces around the one-line if()
>   scsi: bfa: bfa_ioc: Demote non-kerneldoc headers down to standard
>     comment blocks
>   scsi: bfa: bfa_core: Demote seemingly unintentional kerneldoc header
>   scsi: bfa: bfa_svc: Demote seemingly unintentional kerneldoc header
>   scsi: qedi: qedi_main: Demote seemingly unintentional kerneldoc header
>   scsi: qedi: qedi_iscsi: Staticify non-external function
>     'qedi_get_iscsi_error'
>   scsi: bfa: bfa_ioc: Ensure a blank line precedes next function/header
>   scsi: bnx2i: bnx2i_iscsi: Add parameter description and rename another
>   scsi: esas2r: esas2r_log: Demote a few non-conformant kerneldoc
>     headers
> 
> [...]

Applied to 5.9/scsi-next, thanks!

[01/40] scsi: lpfc: Fix some function parameter descriptions
        https://git.kernel.org/mkp/scsi/c/a0e4a64f8650
[02/40] scsi: lpfc: Fix kerneldoc parameter formatting/misnaming/missing issues
        https://git.kernel.org/mkp/scsi/c/e415f2a2acd9
[03/40] scsi: ufs: ufs-qcom: Demote nonconformant kerneldoc headers
        https://git.kernel.org/mkp/scsi/c/bc5b681614cc
[04/40] scsi: bnx2i: Fix parameter misnaming in function header
        https://git.kernel.org/mkp/scsi/c/b4688a7e01e5
[06/40] scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header
        https://git.kernel.org/mkp/scsi/c/b44cc4a40bd6
[07/40] scsi: bfa: Staticify local functions
        https://git.kernel.org/mkp/scsi/c/0aaaa04a7a79
[08/40] scsi: bnx2i: Add missing descriptions for 'attr' parameter
        https://git.kernel.org/mkp/scsi/c/2ad6e0c339d2
[09/40] scsi: bfa: Remove set but unused variable 'rp'
        https://git.kernel.org/mkp/scsi/c/70b4de0bb928
[10/40] scsi: bfa: Demote seemingly unintentional kerneldoc header
        https://git.kernel.org/mkp/scsi/c/7106de1d8a75
[11/40] scsi: qedi: Remove 2 set but unused variables
        https://git.kernel.org/mkp/scsi/c/e4020e0835ed
[12/40] scsi: ips: Remove some set but unused variables
        https://git.kernel.org/mkp/scsi/c/ffe1757e45aa
[13/40] scsi: ips: Convert strnlen() to memcpy() since result should not be NUL terminated
        https://git.kernel.org/mkp/scsi/c/00e245655e75
[14/40] scsi: qla4xxx: Remove set but unused variable 'status'
        https://git.kernel.org/mkp/scsi/c/6e3f4f68821b
[15/40] scsi: lpfc: Use __printf() format notation
        https://git.kernel.org/mkp/scsi/c/7fa03c77cd54
[16/40] scsi: lpfc: Add and rename a whole bunch of function parameter descriptions
        https://git.kernel.org/mkp/scsi/c/fe614acd583f
[17/40] scsi: qla4xxx: Rename function parameter descriptions
        https://git.kernel.org/mkp/scsi/c/d10d1df6301d
[18/40] scsi: lpfc: Fix a bunch of kerneldoc misdemeanors
        https://git.kernel.org/mkp/scsi/c/012d019f5a50
[19/40] scsi: lpfc: Add description for lpfc_release_rpi()'s 'ndlpl param
        https://git.kernel.org/mkp/scsi/c/22f8c077411b
[20/40] scsi: bfa: Remove a few unused variables 'pgoff' and 't'
        https://git.kernel.org/mkp/scsi/c/c7ccd038b729
[21/40] scsi: csiostor: Mark known unused variable as __always_unused
        https://git.kernel.org/mkp/scsi/c/085d46fd2202
[22/40] scsi: csiostor: Remove 2 unused variables {mc,edc}_bist_status_rdata_reg
        https://git.kernel.org/mkp/scsi/c/f11106c93fc9
[23/40] scsi: bfa: Staticify non-external functions
        https://git.kernel.org/mkp/scsi/c/00025fc7e676
[24/40] scsi: csiostor: Add missing description for csio_rnode_fwevt_handler()'s 'fwevt' param
        https://git.kernel.org/mkp/scsi/c/f5816509a2f2
[25/40] scsi: bfa: Demote non-compliant kerneldoc headers to standard comments
        https://git.kernel.org/mkp/scsi/c/eaefa33014bf
[27/40] scsi: bfa: Remove unused variable 'adisc'
        https://git.kernel.org/mkp/scsi/c/e95fcb77921c
[28/40] scsi: bnx2i: Fix a whole host of kerneldoc issues
        https://git.kernel.org/mkp/scsi/c/dd3273c9b10f
[29/40] scsi: bnx2i: Add, remove and edit some function parameter descriptions
        https://git.kernel.org/mkp/scsi/c/89c19a8e5ec3
[30/40] scsi: be2iscsi: Correct misdocumentation of function param 'ep'
        https://git.kernel.org/mkp/scsi/c/c4b68559edf5
[31/40] scsi: qedi: Remove set but unused variable 'tmp'
        https://git.kernel.org/mkp/scsi/c/56d244fe89c9
[32/40] scsi: esas2r: Add braces around the one-line if()
        https://git.kernel.org/mkp/scsi/c/e36e0427a46a
[33/40] scsi: bfa: Demote non-kerneldoc headers down to standard comment blocks
        https://git.kernel.org/mkp/scsi/c/b1a187f2615a
[34/40] scsi: bfa: Demote seemingly unintentional kerneldoc header
        https://git.kernel.org/mkp/scsi/c/310531ffc3c8
[35/40] scsi: bfa: Demote seemingly unintentional kerneldoc header
        https://git.kernel.org/mkp/scsi/c/20e73cb1d03c
[36/40] scsi: qedi: Demote seemingly unintentional kerneldoc header
        https://git.kernel.org/mkp/scsi/c/3db05fed8b58
[37/40] scsi: qedi: Staticify non-external function 'qedi_get_iscsi_error'
        https://git.kernel.org/mkp/scsi/c/010f7c2ab4ad
[38/40] scsi: bfa: Ensure a blank line precedes next function/header
        https://git.kernel.org/mkp/scsi/c/64332c13d0d1
[39/40] scsi: bnx2i: Add parameter description and rename another
        https://git.kernel.org/mkp/scsi/c/a8b6d0ee6e9e
[40/40] scsi: esas2r: Demote a few non-conformant kerneldoc headers
        https://git.kernel.org/mkp/scsi/c/e3903d31826f

-- 
Martin K. Petersen	Oracle Linux Engineering