Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to architecture only

[Paul Cercueil]

Le ven. 24 juil. 2020 à 17:33, Krzysztof Kozlowski <krzk@xxxxxxxxxx> a 
écrit :
> On Fri, 24 Jul 2020 at 17:19, Paul Cercueil <paul@xxxxxxxxxxxxxxx> 
> wrote:
> >  Hi Krzysztof,
> >
> >
> >  Le ven. 24 juil. 2020 à 16:54, Krzysztof Kozlowski 
> > <krzk@xxxxxxxxxx> a
> >  écrit :
> >  > Enabling the MTD_NAND_JZ4780 driver makes sense only for specific
> >  > hardware - the Ingenic SoC architecture.  Set it's dependency to
> >  > MACH_INGENIC so it will not appear on unrelated architectures 
> > (easier
> >  > job for downstream/distro kernel engineers).
> >
> >  Disagreed. It was done this way so that distro kernels can support
> >  multiple SoCs.
>
> They will still be able to support multiple SoCs. Nothing changed
> here. The same we do for all ARM drivers (SoCs are multiplatform)...
> Unless you want to say that it is possible to support Ingenic SoC
> without MACH_INGENIC?

On MIPS, the SoC selection is a Kconfig "choice", so you can only 
support one SoC family, unfortunately. I'm the one to blame for using 
"depends on MIPS || COMPILE_TEST" on ingenic drivers, maybe it should 
depend on MACH_INGENIC indeed, but then it should be made possible to 
support more than one SoC family.

That's something that should be pointed out to the MIPS mailing list, I 
believe.

Btw: Does that mean you are the new maintainer for drivers/memory/?

Cheers,
-Paul

> Best regards,
> Krzysztof