Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes

[Jonathan Marek]

On 7/24/20 10:13 AM, Sibi Sankar wrote:
> Hey Jonathan,
>
> Thanks for the patch! Please use the
> suggested register space definitions
> instead.

Thanks for the suggestions, I was unsure what to use for the sizes. The 
reg field is unused by the upstream driver so it is hard to figure out.

However, I'm not sure about some of your suggestions for the base 
address. For example, for "mc_virt" you suggest 0x0163d000, and I have 
0x09100000. In the downstream dts, "mc_virt-base" is 0x9100000 and 
qcom,base-offset for fab_mc_virt is 0. Do you have an explanation for 
why your suggestion is so different?

> On 2020-07-13 21:11, Jonathan Marek wrote:
> > Add the interconnect dts nodes for sm8250.
> >
> > Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> > ---
> > Âarch/arm64/boot/dts/qcom/sm8250.dtsi | 82 ++++++++++++++++++++++++++++
> > Â1 file changed, 82 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > index 636e2196138c..dfc1b7fa7d85 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > @@ -11,6 +11,7 @@
> > Â#include <dt-bindings/power/qcom-aoss-qmp.h>
> > Â#include <dt-bindings/power/qcom-rpmpd.h>
> > Â#include <dt-bindings/soc/qcom,rpmh-rsc.h>
> > +#include <dt-bindings/interconnect/qcom,sm8250.h>
>
> please fix ^^ sort order
>
> > Â/ {
> > ÂÂÂÂ interrupt-parent = <&intc>;
> > @@ -978,6 +979,55 @@ spi13: spi@a94000 {
> > ÂÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂ };
> >
> > +ÂÂÂÂÂÂÂ config_noc: interconnect@1500000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-config-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x01500000 0 0x1000>;
>
> 0x01500000 0xa580
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ ipa_virt: interconnect@1620000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-ipa-virt";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x01620000 0 0x1000>;
>
> 0x01e00000 0x1000
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ system_noc: interconnect@1632000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-system-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x01632000 0 0x1000>;
>
> 0x01620000 0x1C200
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ aggre1_noc: interconnect@16e2000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-aggre1-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x016e2000 0 0x1000>;
>
> 0x016e0000 0x1f180
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ aggre2_noc: interconnect@1703000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-aggre2-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x01703000 0 0x1000>;
>
> 0x01700000 0x33000
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ compute_noc: interconnect@1733000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-compute-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x01733000 0 0x1000>;
>
> 0x01733000 0xd180
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ mmss_noc: interconnect@174a000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-mmss-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x0174a000 0 0x1000>;
>
> 0x01740000 0x1f080
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > ÂÂÂÂÂÂÂÂ ufs_mem_hc: ufshc@1d84000 {
> > ÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-ufshc", "qcom,ufshc",
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "jedec,ufs-2.0";
> > @@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 {
> > ÂÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂ };
> >
> > +ÂÂÂÂÂÂÂ dc_noc: interconnect@90c0000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-dc-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x090c0000 0 0x1000>;
>
> 0x090c0000 0x4200
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ mc_virt: interconnect@9100000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-mc-virt";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x09100000 0 0x1000>;
>
> 0x0163d000 0x1000
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ gem_noc: interconnect@9121000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-gem-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x09121000 0 0x1000>;
>
> 0x09100000 0xb4000
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ npu_noc: interconnect@9990000 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-npu-noc";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x09990000 0 0x1000>;
>
> 0x09990000 0x1600
>
> > +ÂÂÂÂÂÂÂÂÂÂÂ #interconnect-cells = <1>;
> > +ÂÂÂÂÂÂÂÂÂÂÂ qcom,bcm-voters = <&apps_bcm_voter>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > ÂÂÂÂÂÂÂÂ usb_1: usb@a6f8800 {
> > ÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,sm8250-dwc3", "qcom,dwc3";
> > ÂÂÂÂÂÂÂÂÂÂÂÂ reg = <0 0x0a6f8800 0 0x400>;
> > @@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂÂÂÂÂ apps_bcm_voter: bcm_voter {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "qcom,bcm-voter";
> > +ÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂ };