Re: [PATCH -next] arm64: Export __cpu_logical_map

[Kefeng Wang]

On 2020/7/24 16:16, Anshuman Khandual wrote:
> On 07/24/2020 08:38 AM, Kefeng Wang wrote:
> > +maillist
> This does not seem to be a correct method of posting any patch.
sorryï forget to cc mailist when git send-email
> > On 2020/7/24 11:04, Kefeng Wang wrote:
> > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined!
>
> > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export
> > > __cpu_logical_map to fix build issue.
> Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds
> this particular driver is present just on linux-next. But as expected,
> the driver does not use __cpu_logical_map directly but instead accesses
> it via cpu_logical_map() wrapper. Wondering, how did you even trigger
> the modpost error ?

arch/arm64/include/asm/smp.h:#define cpu_logical_map(cpu) 
__cpu_logical_map[cpu]

Will see the error when using allmodconfig to build.

> > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > > Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> > > ---
> > >  Â arch/arm64/kernel/setup.c | 1 +
> > >  Â 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> > > index c793276ec7ad9..3aea05fbb9998 100644
> > > --- a/arch/arm64/kernel/setup.c
> > > +++ b/arch/arm64/kernel/setup.c
> > > @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void)
> > >  Â arch_initcall(reserve_memblock_reserved_regions);
> > >  Â Â u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
> > > +EXPORT_SYMBOL(__cpu_logical_map);
> > >  Â Â void __init setup_arch(char **cmdline_p)
> > >  Â {
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> .