Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path

[Pkshih]

On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The variables ant_num and single_ant_path are being initialized with a
> value that is never read and are being updated later with a new value.
> The initializations are redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Thank you

> ---
> Âdrivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index a4940a3842de..4949f99844b5 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -1318,7 +1318,7 @@ bool exhalbtc_bind_bt_coex_withadapter(void *adapter)
> Â{
> Â	struct rtl_priv *rtlpriv = adapter;
> Â	struct btc_coexist *btcoexist = rtl_btc_coexist(rtlpriv);
> -	u8 ant_num = 2, chip_type, single_ant_path = 0;
> +	u8 ant_num, chip_type, single_ant_path;
> Â
> Â	if (!btcoexist)
> Â		return false;