Re: [PATCH] drm/bridge/adv7511: set the bridge type properly

From: Vinod Koul
Date: Fri Jul 24 2020 - 00:22:35 EST


On 22-07-20, 15:15, Laurent Pinchart wrote:
> Hi Laurentiu,
>
> Thank you for the patch.
>
> On Mon, Jul 20, 2020 at 03:42:27PM +0300, Laurentiu Palcu wrote:
> > From: Laurentiu Palcu <laurentiu.palcu@xxxxxxx>
> >
> > After the drm_bridge_connector_init() helper function has been added, the ADV
> > driver has been changed accordingly. However, the 'type' field of the bridge
> > structure was left unset, which makes the helper function always return -EINVAL.
> >
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks Laurent for pointing me to this.

Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>

I have tested this on DragonBoard 410c:

Tested-by: Vinod Koul <vkoul@xxxxxxxxxx>

--
~Vinod