Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx

From: Al Viro
Date: Sun Jul 19 2020 - 12:58:00 EST


On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote:
> ping Al Viro
>
> Could you please help to review this patch? Thanks a lot.

That's -next, right? As for the patch itself... Frankly,
Daniel's patch looks seriously wrong.
* why has O_CLOEXEC been quietly smuggled in? It's
a userland ABI change, for fsck sake...
* the double-put you've spotted
* the whole out: thing - just make it
if (IS_ERR(file)) {
userfaultfd_ctx_put(ctx);
return PTR_ERR(file);
}
and be done with that.