Re: [PATCH] hwmon: (adm1025) Replace HTTP links with HTTPS ones
From: Guenter Roeck
Date: Sat Jul 18 2020 - 11:14:08 EST
On Mon, Jul 13, 2020 at 04:00:28PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>
Applied.
Guenter
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely or at least not just HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> drivers/hwmon/adm1025.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/adm1025.c b/drivers/hwmon/adm1025.c
> index ae7b96945185..ed15185fa60f 100644
> --- a/drivers/hwmon/adm1025.c
> +++ b/drivers/hwmon/adm1025.c
> @@ -13,7 +13,7 @@
> * resolution of about 0.5% of the nominal value). Temperature values are
> * reported with a 1 deg resolution and a 3 deg accuracy. Complete
> * datasheet can be obtained from Analog's website at:
> - * http://www.onsemi.com/PowerSolutions/product.do?id=ADM1025
> + * https://www.onsemi.com/PowerSolutions/product.do?id=ADM1025
> *
> * This driver also supports the ADM1025A, which differs from the ADM1025
> * only in that it has "open-drain VID inputs while the ADM1025 has