Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device

From: Chris Healy
Date: Tue Jul 07 2020 - 20:42:53 EST


On Tue, Jul 7, 2020 at 5:41 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> Hi Chris,
>
> On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <cphealy@xxxxxxxxx> wrote:
>
> > #address-cells = <1>;
> > #size-cells = <0>;
> > status = "okay";
> > + suppress-preamble;
> > + clock-frequency = <12500000>;
>
> Sorry, I missed this in the previous review.
>
> The recommendation is to have status = okay as the last property.
>
> Please move suppress-preamble and clock-frequency = <12500000> prior
> to status = "okay"

Will do in the next version.