Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert battery.txt to battery.yaml

[Ricardo Rivera-Matos]

On 7/7/20 9:40 AM, Rob Herring wrote:
> On Mon, Jul 6, 2020 at 12:45 PM Ricardo Rivera-Matos
> <r-rivera-matos@xxxxxx> wrote:
> > Rob
> >
> > On 7/2/20 3:53 PM, Rob Herring wrote:
> > > On Wed, 01 Jul 2020 16:10:42 -0500, Ricardo Rivera-Matos wrote:
> > > > From: Dan Murphy <dmurphy@xxxxxx>
> > > >
> > > > Convert the battery.txt file to yaml and fix up the examples.
> > > >
> > > > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > > > ---
> > > >    .../bindings/power/supply/battery.txt         |  86 +---------
> > > >    .../bindings/power/supply/battery.yaml        | 157 ++++++++++++++++++
> > > >    2 files changed, 158 insertions(+), 85 deletions(-)
> > > >    create mode 100644 Documentation/devicetree/bindings/power/supply/battery.yaml
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> > > Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/power/supply/battery.example.dts' failed
> > > make[1]: *** [Documentation/devicetree/bindings/power/supply/battery.example.dts] Error 255
> > > make[1]: *** Waiting for unfinished jobs....
> > > Makefile:1347: recipe for target 'dt_binding_check' failed
> > > make: *** [dt_binding_check] Error 2
> > I think your bot is looking for the types.yaml in the wrong place.
> Really? Yet it works fine on thousands of other patches?
>
> > '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> > should be
> > '/usr/local/lib/python3.6/dist-packages/dtschema/schemas/types.yaml'. I
> > renamed might 'schemas' directory to 'schema' and my battery.yaml passed
> > the dt_binding_check.
> Maybe fix the 'schema/' path in your schema file which is wrong.
Oh I see. My apologies, Rob.
> Rob