Re: [RESEND 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase()

[Linus Walleij]

On Thu, Jun 25, 2020 at 9:17 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> There isn't any code present within the current kernel to
> override this 'weak' function.  Besides returning '0', which
> is never checked anyway, the whole function appears to be
> superfluous.
>
> Consequently fixes W=1 warning:
>
>  drivers/regulator/dbx500-prcmu.c:113:27: warning: no previous prototype for âdbx500_regulator_testcaseâ [-Wmissing-prototypes]
>  113 | int __attribute__((weak)) dbx500_regulator_testcase(
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij