Re: [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile

From: Jann Horn
Date: Mon Jul 06 2020 - 09:50:42 EST


On Mon, Jul 6, 2020 at 3:34 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> If the header file containing a function's prototype isn't included by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/usb/early/ehci-dbgp.c: In function âearly_dbgp_writeâ:
> drivers/usb/early/ehci-dbgp.c:915:13: warning: variable âretâ set but not used [-Wunused-but-set-variable]
> 915 | int chunk, ret;
> | ^~~
> drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for âearly_xdbc_parse_parameterâ [-Wmissing-prototypes]
> 600 | int __init early_xdbc_parse_parameter(char *s)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for âearly_xdbc_setup_hardwareâ [-Wmissing-prototypes]
> 653 | int __init early_xdbc_setup_hardware(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for âearly_xdbc_register_consoleâ [-Wmissing-prototypes]
> 910 | void __init early_xdbc_register_console(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Jann Horn <jannh@xxxxxxxxxx>
> Cc: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Jann Horn <jannh@xxxxxxxxxx>