Re: [PATCH] lib/test_bitops: Do the full test during module init

From: Geert Uytterhoeven
Date: Mon Jul 06 2020 - 07:29:07 EST


Hi Andy,

On Mon, Jul 6, 2020 at 12:39 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, Jul 6, 2020 at 12:53 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > Currently, the bitops test consists of two parts: one part is executed
> > during module load, the second part during module unload. This is
> > cumbersome for the user, as he has to perform two steps to execute all
> > tests, and is different from most (all?) other tests.
> >
> > Merge the two parts, so both are executed during module load.
>
> Does your change prevent you from unloading the module?

Good point, you need a dummy module_exit() for that.
Stay tuned for v2.

Gr{oetje,eeting}s,

Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds