Re: [PATCH] Replace HTTP links with HTTPS ones: Hyper-V core and drivers

From: Wei Liu
Date: Mon Jul 06 2020 - 06:40:59 EST


On Sun, Jul 05, 2020 at 11:44:57PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>

Thanks for the patch.

I will reword the subject line to be more specific to:

tools: hv: change http to https in hv_kvp_daemon.c

.

> ---
> Continuing my work started at 93431e0607e5.
>
> If there are any URLs to be removed completely or at least not HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See https://lkml.org/lkml/2020/6/26/837
>
> tools/hv/hv_kvp_daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index ee9c1bb2293e..1e6fd6ca513b 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -437,7 +437,7 @@ void kvp_get_os_info(void)
>
> /*
> * Parse the /etc/os-release file if present:
> - * http://www.freedesktop.org/software/systemd/man/os-release.html
> + * https://www.freedesktop.org/software/systemd/man/os-release.html
> */
> file = fopen("/etc/os-release", "r");
> if (file != NULL) {
> --
> 2.27.0
>