Re: [PATCH v5 03/14] irqchip/csky-mpintc: Fix potential resource leaks

From: Markus Elfring
Date: Mon Jul 06 2020 - 02:15:53 EST


> â Thus add jump targets for the completion of the desired
> exception handling. By the way, do some coding-style cleanups
> suggested by Markus.

I propose to split these changes.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258#n138

Would you like to support easier back-porting of a fix
besides another bit of possible source code beautification?


â
+++ b/drivers/irqchip/irq-csky-mpintc.c
@@ -241,14 +241,16 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
â
INTCG_base = ioremap(mfcr("cr<31, 14>"),
- INTCL_SIZE*nr_cpu_ids + INTCG_SIZE);
â
+ INTCL_SIZE * nr_cpu_ids + INTCG_SIZE);

Can any macro (or function) be helpful for such a size computation?

Regards,
Markus