Re: [mm] 4e2c82a409: ltp.overcommit_memory01.fail

From: Qian Cai
Date: Sun Jul 05 2020 - 08:15:09 EST




> On Jul 5, 2020, at 12:45 AM, Feng Tang <feng.tang@xxxxxxxxx> wrote:
>
> I did reproduce the problem, and from the debugging, this should
> be the same root cause as lore.kernel.org/lkml/20200526181459.GD991@xxxxxx/
> that loosing the batch cause some accuracy problem, and the solution of
> adding some sync is still needed, which is dicussed in

Well, before taking any of those patches now to fix the regression, we will need some performance data first. If it turned out the original performance gain is no longer relevant anymore due to this regression fix on top, it is best to drop this patchset and restore that VM_WARN_ONCE, so you can retry later once you found a better way to optimize.