Re: [for-next][PATCH 8/8] ktest.pl: Add MAIL_MAX_SIZE to limit the amount of log emailed

From: Greg KH
Date: Thu Jul 02 2020 - 08:34:03 EST


On Thu, Jul 02, 2020 at 08:19:49AM -0400, Steven Rostedt wrote:
> On Thu, 2 Jul 2020 09:41:03 +0200
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Wed, Jul 01, 2020 at 07:17:25PM -0400, Steven Rostedt wrote:
> > > From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
> > >
> > > Add the ktest config option MAIL_MAX_SIZE that will limit the size of the
> > > log file that is placed into the email on failure.
> > >
> > > Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> > > ---
> > > tools/testing/ktest/ktest.pl | 12 +++++++++++-
> > > tools/testing/ktest/sample.conf | 13 +++++++++++++
> > > 2 files changed, 24 insertions(+), 1 deletion(-)
> >
> > Interesting, but I like full log files for my reports :)
>
> I can add an option to do that if you want. My full logs end up being a
> few hundred megabytes. Perhaps I could add a compress option too.

It's fine, the default should be good enough for me for now. If not,
I'll just bump the value, or add compression.

thanks,

greg k-h-