Re: [PATCH v2 1/1] dt-bindings: MIPS: Document Ingenic SoCs binding.

From: Thomas Bogendoerfer
Date: Thu Jul 02 2020 - 06:12:57 EST


On Mon, Jun 29, 2020 at 04:28:31PM -0300, Fabio Estevam wrote:
> On Fri, Jun 19, 2020 at 9:48 AM Thomas Bogendoerfer
> <tsbogend@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Jun 03, 2020 at 02:33:54AM +0800, åçæ (Zhou Yanjie) wrote:
> > > Document the available properties for the SoC root node and the
> > > CPU nodes of the devicetree for the Ingenic XBurst SoCs.
> > >
> > > Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> > > Tested-by: Paul Boddie <paul@xxxxxxxxxxxxx>
> > > Signed-off-by: åçæ (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > > ---
> > >
> > > Notes:
> > > v1->v2:
> > > 1.Remove unnecessary "items".
> > > 2.Add "clocks" as suggested by Paul Cercueil.
> > >
> > > .../bindings/mips/ingenic/ingenic,cpu.yaml | 67 ++++++++++++++++++++++
> > > 1 file changed, 67 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> >
> > applied to mips-next.
>
> This causes 'make dt_binding_check' to fail:
>
> $ make dt_binding_check
> CHKDT Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml:
> while scanning a block scalar
> in "<unicode string>", line 42, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 46, column 1
> Documentation/devicetree/bindings/Makefile:20: recipe for target
> 'Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.example.dts'
> failed
> make[1]: *** [Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.example.dts]
> Error 1
> Makefile:1343: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2


thank you for noticing. It's my fault, I've changed spaces into tabs while
applying, which is of course wrong for yaml files... I've commited a fix
for this to mips-next and 'make dt_binding_check' now passes for me.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]