Re: [PATCH v2] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

From: Krzysztof Kozlowski
Date: Thu Jul 02 2020 - 02:16:28 EST


On Tue, Jun 30, 2020 at 08:27:01AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 29.06.2020 22:59, Krzysztof Kozlowski wrote:
> > Remove the regulators node entirely because its children do not have any
> > unit addresses. This fixes DTC warning:
> >
> > Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>
> What about removing the regulators node from other boards:
> exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts?
>
> On the other hand, maybe it would be really easier to add missing
> address/size-cells properties to exynos4210-trats.dts/regulators node?

Indeed let's keep it consistent so in such case better to add here
proper address/size-cells.

Thanks for feedback!

Best regards,
Krzysztof