[PATCH 09/15] mmc: host: rtsx_pci_sdmmc: Remove set but unused variable 'err'

From: Lee Jones
Date: Wed Jul 01 2020 - 08:47:54 EST


Seeing as sd_wait_data_idle() returns void and only a very specific
read value is checked, there doesn't seem to be a good reason to
check the return value of rtsx_pci_read_register(). So remove
the assignment and definition of 'err'.

Squashes the following W=1 kernel build warning:

drivers/mmc/host/rtsx_pci_sdmmc.c: In function âsd_wait_data_idleâ:
drivers/mmc/host/rtsx_pci_sdmmc.c:678:6: warning: variable âerrâ set but not used [-Wunused-but-set-variable]
678 | int err, i;
| ^~~

Cc: Wei WANG <wei_wang@xxxxxxxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
---
drivers/mmc/host/rtsx_pci_sdmmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index 5a71f6678fd3a..dc0dbd64a2a78 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -675,11 +675,11 @@ static u8 sd_search_final_phase(struct realtek_pci_sdmmc *host, u32 phase_map)

static void sd_wait_data_idle(struct realtek_pci_sdmmc *host)
{
- int err, i;
+ int i;
u8 val = 0;

for (i = 0; i < 100; i++) {
- err = rtsx_pci_read_register(host->pcr, SD_DATA_STATE, &val);
+ rtsx_pci_read_register(host->pcr, SD_DATA_STATE, &val);
if (val & SD_DATA_IDLE)
return;

--
2.25.1