Re: [PATCH v4 03/14] irqchip/csky-mpintc: Fix potential resource leaks

[Tiezhu Yang]

On 07/01/2020 03:49 PM, Markus Elfring wrote:
> > exception handling. By the way, do some coding-style cleanups
> I propose to consider another bit of fine-tuning.
>
>
> â
> > +++ b/drivers/irqchip/irq-csky-mpintc.c
> â
> > @@ -270,12 +274,24 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
> >
> >   #ifdef CONFIG_SMP
> >   	ipi_irq = irq_create_mapping(root_domain, IPI_IRQ);
> > -	if (!ipi_irq)
> > -		return -EIO;
> > +	if (!ipi_irq) {
> > +		ret = -EIO;
> > +		goto err_domain_remove;
> How do you think about to use the following source code variant
> at this place?
>
> +		irq_domain_remove(root_domain);
> +		ret = -EIO;
> +		goto err_iounmap;
>
>
> Would you like to avoid the repetition of the check â#ifdef CONFIG_SMPâ?

OK, thank you, it looks good to me, I will do it in v5.

> Regards,
> Markus