Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC

[Lee Jones]

On Fri, 19 Jun 2020, Gene Chen wrote:

> From: Gene Chen <gene_chen@xxxxxxxxxxx>
> 
> imlement i2c R/W with CRC when access sub-device PMIC and LDO part

Please use proper grammar, including capital letters at the start of
the sentence and for abbreviations such as "I2C" and full stops.

Also this doesn't make sense to me.  Please elaborate.

> Signed-off-by: Gene Chen <gene_chen@xxxxxxxxxxx>
> ---
>  drivers/mfd/Kconfig        |   1 +
>  drivers/mfd/mt6360-core.c  | 541 +++++++++++++++++++++++++++++----------------

This patch is doing way too much wacky stuff all at once, making it
very difficult to review.  Please break it up into functional pieces
and submit as separate logical patches (in a set of course).

>  include/linux/mfd/mt6360.h | 240 --------------------
>  3 files changed, 357 insertions(+), 425 deletions(-)
>  delete mode 100644 include/linux/mfd/mt6360.h

-- 
Lee Jones [æçæ]
Senior Technical Lead - Developer Services
Linaro.org â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog