Re: [regression] TCP_MD5SIG on established sockets

From: Herbert Xu
Date: Tue Jun 30 2020 - 22:58:58 EST


On Tue, Jun 30, 2020 at 07:30:43PM -0700, Eric Dumazet wrote:
>
> I made this clear in the changelog, do we want comments all over the places ?
> Do not get me wrong, we had this bug for years and suddenly this is a
> big deal...

I thought you were adding a new pair of smp_rmb/smp_wmb. If they
already exist in the code then I agree it's not a big deal. But
adding a new pair of bogus smp_Xmb's is bad for maintenance.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt