RE: [PATCH] igb: reinit_locked() should be called with rtnl_lock

[Kirsher, Jeffrey T]

> -----Original Message-----
> From: Francesco Ruggeri <fruggeri@xxxxxxxxxx>
> Sent: Monday, June 29, 2020 21:51
> To: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: open list <linux-kernel@xxxxxxxxxxxxxxx>; netdev
> <netdev@xxxxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; David Miller
> <davem@xxxxxxxxxxxxx>; Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>
> Subject: Re: [PATCH] igb: reinit_locked() should be called with rtnl_lock
> 
> > Would you mind adding a fixes tag here? Probably:
> >
> > Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver")
> 
> That seems to be the commit that introduced the driver in 2.6.25.
> I am not familiar with the history of the driver to tell if this was a day 1
> problem or if it became an issue later.
> 
> >
> > And as a matter of fact it looks like e1000e and e1000 have the same
> > bug :/ Would you mind checking all Intel driver producing matches for
> > all the affected ones?
> 
> Do you mean identify all Intel drivers that may have the same issue?
> 

Do not worry about the other Intel drivers, I have our developers looking at each of our drivers for the locking issue.

@David Miller - I am picking up this patch