RE: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use

From: Asmaa Mnebhi
Date: Tue Jun 30 2020 - 10:17:28 EST


Reviewed-by: Asmaa Mnebhi <asmaa@xxxxxxxxxxxx>

Thank you.

-----Original Message-----
From: Lee Jones <lee.jones@xxxxxxxxxx>
Sent: Tuesday, June 30, 2020 9:34 AM
To: linus.walleij@xxxxxxxxxx; bgolaszewski@xxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; Lee Jones <lee.jones@xxxxxxxxxx>; Asmaa Mnebhi <Asmaa@xxxxxxxxxxxx>
Subject: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use

... as is the case when !CONFIG_ACPI.

Fixes the following W=1 kernel build warning:

drivers/gpio/gpio-mlxbf2.c:312:36: warning: âmlxbf2_gpio_acpi_matchâ defined but not used [-Wunused-const-variable=]
312 | static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~~

Cc: Asmaa Mnebhi <Asmaa@xxxxxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
---
drivers/gpio/gpio-mlxbf2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 94d5efce1721c..861a8d0a84be0 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -309,7 +309,7 @@ static int mlxbf2_gpio_resume(struct platform_device *pdev) } #endif

-static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = {
+static const struct acpi_device_id __maybe_unused
+mlxbf2_gpio_acpi_match[] = {
{ "MLNXBF22", 0 },
{},
};
--
2.25.1