Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver

From: Richard Weinberger
Date: Tue Jun 30 2020 - 05:14:08 EST


On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello
<christophe.kerello@xxxxxx> wrote:
>
> The driver adds the support for the STMicroelectronics FMC2 EBI controller
> found on STM32MP SOCs.
>
> Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxx>
> ---
> + if (!IS_ERR(rstc)) {
> + reset_control_assert(rstc);
> + reset_control_deassert(rstc);

Shouldn't there be a small delay between assert and deassert?
Other than that the code looks good to me.

--
Thanks,
//richard