Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

From: Christoph Hellwig
Date: Tue Jun 30 2020 - 03:04:41 EST


Next fund one, in net/ipv6/ip6_flowlabel.c:ipv6_flowlabel_opt() we
have this gem toward the end:

if (!freq->flr_label) {
if (copy_to_user(&((struct in6_flowlabel_req __user *)optval)->flr_label,
&fl->label, sizeof(fl->label))) {
/* Intentionally ignore fault. */

so it writes back to what was supposed to be the input parameter,
and only does it for a partial region. Not sure how we could handle
that with any kind of copy to kernel in the caller scheme?