Re: [PATCH] spi: spi-geni-qcom: Don't set the cs if it was already right

From: Doug Anderson
Date: Mon Jun 29 2020 - 19:45:47 EST


Hi,

On Mon, Jun 29, 2020 at 4:53 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Jun 26, 2020 at 03:19:50PM -0700, Douglas Anderson wrote:
> > Setting the chip select on the Qualcomm geni SPI controller isn't
> > exactly cheap. Let's cache the current setting and avoid setting the
> > chip select if it's already right.
>
> Seems like it'd be worth pushing this up to the core - if we're
> constantly setting the same CS value then perhaps we ought to just stop
> doing that?

Posted:

spi: Avoid setting the chip select if we don't need to
20200629164103.1.Ied8e8ad8bbb2df7f947e3bc5ea1c315e041785a2@changeid">https://lore.kernel.org/r/20200629164103.1.Ied8e8ad8bbb2df7f947e3bc5ea1c315e041785a2@changeid

I see that you applied my patch to "spi-geni-qcom". If the patch to
the core looks OK to you and lands, I think the one for the driver can
be reverted (though it doesn't hurt).

-Doug