Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Add PM support

[Guenter Roeck]

On Mon, Jun 29, 2020 at 9:13 AM Prashant Malani <pmalani@xxxxxxxxxxxx> wrote:
>
> Define basic suspend resume functions for cros-ec-typec. On suspend, we
> simply ensure that any pending port update work is completed, and on
> resume, we re-poll the port state to account for any
> changes/disconnections that might have occurred during suspend.
>
> Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
> ---
>
> Changes in v2:
> - Remove #ifdef-ery, add __maybe_unused tag to functions.
>
>  drivers/platform/chrome/cros_ec_typec.c | 26 +++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 630170fb2cbe..b2e7e928e788 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -725,11 +725,37 @@ static int cros_typec_probe(struct platform_device *pdev)
>         return ret;
>  }
>
> +static int __maybe_unused cros_typec_suspend(struct device *dev)
> +{
> +       struct cros_typec_data *typec = dev_get_drvdata(dev);
> +
> +       cancel_work_sync(&typec->port_work);
> +
> +       return 0;
> +}
> +
> +static int __maybe_unused cros_typec_resume(struct device *dev)
> +{
> +       struct cros_typec_data *typec = dev_get_drvdata(dev);
> +
> +       /* Refresh port state. */
> +       schedule_work(&typec->port_work);
> +
> +       return 0;
> +}
> +
> +static const struct dev_pm_ops cros_typec_pm_ops = {
> +       SET_SYSTEM_SLEEP_PM_OPS(cros_typec_suspend, cros_typec_resume)
> +};
> +
> +#define DEV_PM_OPS     (&cros_typec_pm_ops)

I don't think this define adds any value.

> +
>  static struct platform_driver cros_typec_driver = {
>         .driver = {
>                 .name = DRV_NAME,
>                 .acpi_match_table = ACPI_PTR(cros_typec_acpi_id),
>                 .of_match_table = of_match_ptr(cros_typec_of_match),
> +               .pm = DEV_PM_OPS,
>         },
>         .probe = cros_typec_probe,
>  };
> --
> 2.27.0.212.ge8ba1cc988-goog
>