Re: [PATCH] Remove handhelds.org links and email addresses

[Wolfram Sang]

Hi Alexander,

thanks for trying to fix this, yet I have some doubts.

On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:
> Rationale:
> https://lore.kernel.org/linux-doc/20200626110706.7b5d4a38@xxxxxxx/

I think we need some text here. Clicking on a link to understand what a
patch is about is not comfortable. You can add the link with a Link: tag
for additional information.

Removing stale email addresses may have some value, but removing...

>  Compaq's Bootldr + John Dorsey's patch for Assabet support
> -(http://www.handhelds.org/Compaq/bootldr.html)

... information like this is not good. 'Wayback machine' still has
copies in case someone wants to look at where the infos came from.

> - * Copyright 2004-2005  Phil Blundell <pb@xxxxxxxxxxxxx>
> + * Copyright 2004-2005  Phil Blundell

This is an OK case in my book...


> -MODULE_AUTHOR("Phil Blundell <pb@xxxxxxxxxxxxx>");
> +MODULE_AUTHOR("Phil Blundell");

... same here ...

> @@ -435,7 +435,6 @@
>                             case a PCI bridge (DEC chip 21152). The value of
>                             'pb' is now only initialized if a de4x5 chip is
>                             present.
> -                           <france@xxxxxxxxxxxxx>

This is kind of a signature and should be kept IMO.

>   * 2001/07/23: <rmk@xxxxxxxxxxxxxxxx>
> - *	- Hand merge version from handhelds.org CVS tree.  See patch
> + *	- Hand merge version from CVS tree.  See patch

That information may be useful.


>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /* -*- linux-c -*-
> - *
> - * (C) 2003 zecke@xxxxxxxxxxxxx

Removing copyright is a bad idea.

Probably some comment blocks are cruft meanwhile and can be removed as a
whole. That can be discussed. But removing only the handhelds.org part
makes most parts worse IMHO.

Thanks and happy hacking,

   Wolfram

Attachment: signature.asc
Description: PGP signature