Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build

From: Arnd Bergmann
Date: Mon Jun 29 2020 - 17:01:27 EST


On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <Anson.Huang@xxxxxxx> wrote:
>
> Keep __setup_param() to use same parameters for both built in
> and built as module, it can make the drivers which call it easier
> when the drivers can be built in or built as module.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>

I wonder if we should instead drop the __setup() and __setup_param()
definitions from the #else block here. This was clearly not used anywhere,
and it sounds like any possible user is broken and should be changed to
not use __setup() anyway.

Arnd