Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle

From: Florian Fainelli
Date: Mon Jun 29 2020 - 16:56:43 EST




On 6/29/2020 5:47 AM, Lee Jones wrote:
> 'dc' here is an unsigned long, thus checking for <0 will always
> evaluate to false.
>
> Fixes the following W=1 warning:
>
> drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: Ray Jui <rjui@xxxxxxxxxxxx>
> Cc: Scott Branden <sbranden@xxxxxxxxxxxx>
> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
> Cc: linux-pwm@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you
remove it as well, you can add:

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian