Re: [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

From: Sylwester Nawrocki
Date: Mon Jun 29 2020 - 15:50:35 EST


Hi Krzysztof,

On 6/29/20 21:33, Krzysztof Kozlowski wrote:
Remove the simple-bus compatible from a regulators node because its
children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
---
arch/arm/boot/dts/exynos4210-trats.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 3d791db6095c..cec413ee4490 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -31,8 +31,6 @@
};
regulators {
- compatible = "simple-bus";

I think you would also need to remove the 'regulators' node altogether, otherwise with your change the subnodes below won't get parsed and the regulators will not get registered.

vemmc_reg: regulator-0 {
compatible = "regulator-fixed";
regulator-name = "VMEM_VDD_2.8V";


--
Thanks,
Sylwester