Re: [PATCH] ath10k: Add history for tracking certain events
From: Ben Greear
Date: Sun Jun 28 2020 - 13:25:41 EST
On 06/27/2020 10:12 PM, Rakesh Pillai wrote:
-----Original Message-----
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Sent: Saturday, June 27, 2020 8:58 PM
To: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>; ath10k@xxxxxxxxxxxxxxxxxxx
Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] ath10k: Add history for tracking certain events
On 06/26/2020 11:22 PM, Rakesh Pillai wrote:
For debugging many issues, a history of the
below mentioned events can help get an idea
of what exactly was going on just before any
issue occurred in the system. These event
history will be collected only when the host
driver is run in debug mode (i.e. with the
config ATH10K_DEBUG enabled).
This should be disabled by default unless user specifically pokes some
debugfs
value to turn it on so that it does not impact performance.
Hi Ben,
This history is enabled only if the user compiles the kernel with
ATH10K_DEBUG.
Making it runtime, adds a lot of "if" conditions for this history record.
Do you suggest to add support to enable/disable it runtime even in
ATH10K_DEBUG ?
Yes, because you are adding lots of locks/unlocks. That is way more expensive
than an if statement. You can add an 'unlikely' to the if check as well, so
compiler will optimize for this feature not being enabled.
Thanks,
Ben
Thanks,
Ben
Add history for tracking the below events
- register read
- register write
- IRQ trigger
- IRQ Enable
- IRQ Disable
- NAPI poll
- CE service
- WMI cmd
- WMI event
- WMI tx completion
This will help in debugging any crash or any
improper behaviour.
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com