Re: [RFC 00/10] perf tools: Add support to reuse metric

From: Arnaldo Carvalho de Melo
Date: Sat Jun 27 2020 - 08:48:41 EST


Em Fri, Jun 26, 2020 at 02:57:59PM -0700, Andi Kleen escreveu:
> > The name could be a metric or an event, the logic for each is quite
>
> I would say collisions are unlikely. Event names follow quite structured
> patterns.

And when introducing a new metric the build process can detect that
clash and fail.

> > different. You could look up an event and when it fails assume it was
> > a metric, but I like the simplicity of this approach.

> I don't think it's simpler for the user.

Agreed.

> > Maybe this
> > change could be adopted more widely with something like "perf stat -e
> > metric:IPC -a -I 1000" rather than the current "perf stat -M IPC -a -I
> > 1000".
>
> I thought about just adding metrics to -e, without metric: of course.

Ditto.

- Arnaldo