Re: linux-next: build failure after merge of the akpm-current tree

From: Kees Cook
Date: Fri Jun 26 2020 - 17:08:10 EST


On Fri, Jun 26, 2020 at 05:06:03PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the akpm-current tree, today's linux-next build (sparc
> defconfig) failed like this:
>
> mm/slab.c: In function '___cache_free':
> mm/slab.c:3471:2: error: implicit declaration of function '__free_one'; did you mean '__free_page'? [-Werror=implicit-function-declaration]
> __free_one(ac, objp);
> ^~~~~~~~~~
> __free_page
>
>
> Caused by commit
>
> 1420b22124be ("mm/slab: add naive detection of double free")
>
> __free_one() is ony defined when CONFIG_NUMA is set but used more
> generally.
>
> I have reverted that commit for today.

Thanks! Just to close the loop here, Randy also pointed this out and
I've sent a fix:
https://lore.kernel.org/lkml/1de6b098-a759-dd96-df5d-9a282b2a991b@xxxxxxxxxxxxx/

--
Kees Cook