Re: [PATCH 4.19 012/206] ALSA: hda/realtek - Introduce polarity for micmute LED GPIO

[Sasha Levin]

On Thu, Jun 25, 2020 at 09:02:55PM +0200, Pavel Machek wrote:
> Hi!
>
> > Currently mute LED and micmute LED share the same GPIO polarity.
> >
> > So split the polarity for mute and micmute, in case they have different
> > polarities.
>
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -94,6 +94,7 @@ struct alc_spec {
> >
> >  	/* mute LED for HP laptops, see alc269_fixup_mic_mute_hook() */
> >  	int mute_led_polarity;
> > +	int micmute_led_polarity;
> >  	hda_nid_t mute_led_nid;
> >  	hda_nid_t cap_mute_led_nid;
>
> This variable will be always zero in 4.19.130... so the patch does not
> really do anything.
>
> In mainline, commit 3e0650ab26e20 makes use of this variable.

I'll queue 3e0650ab26e20 for 4.19, thanks!

--
Thanks,
Sasha