Re: [PATCH RFC] s390x/vmem: get rid of memory segment list

From: David Hildenbrand
Date: Thu Jun 25 2020 - 15:55:14 EST




> Am 25.06.2020 um 21:38 schrieb Heiko Carstens <heiko.carstens@xxxxxxxxxx>:
>
> ïOn Thu, Jun 25, 2020 at 05:00:29PM +0200, David Hildenbrand wrote:
>> This smells like a leftover from ancient times, let's get rid of it. We
>> can now convert vmem_remove_mapping() into a void function - everybody
>> ignored the return value already.
>
> This buys us what? Except that we get rid of a bit of code?

Iâm looking into virtio-mem support for s390x, including vmemmap/vmem optimizations. Virtio-mem adds/removes memory in memory block granularity, which results in one list entry for essentially each memory section. That seems to be easy to avoid.

Thanks