Re: [PATCH 01/10] mfd: cros_ec_dev: Fix cros_feature_to_{name,cells} struct descriptions

From: Enric Balletbo i Serra
Date: Thu Jun 25 2020 - 12:35:56 EST


Hi Lee,

Thank you for fixing this.

On 25/6/20 18:31, Lee Jones wrote:
> Kerneldoc expects kernel structures to be prefixed with 'struct'.
>
> Fixes the following W=1 level warnings:
>
> drivers/mfd/cros_ec_dev.c:32: warning: cannot understand function prototype: 'struct cros_feature_to_name '
> drivers/mfd/cros_ec_dev.c:44: warning: cannot understand function prototype: 'struct cros_feature_to_cells '
>
> Cc: Benson Leung <bleung@xxxxxxxxxxxx>
> Cc: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> Cc: Guenter Roeck <groeck@xxxxxxxxxxxx>
> Cc: Bill Richardson <wfrichar@xxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

> ---
> drivers/mfd/cros_ec_dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 32c2b912b58b2..d07b43d7c761a 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -24,7 +24,7 @@ static struct class cros_class = {
> };
>
> /**
> - * cros_feature_to_name - CrOS feature id to name/short description.
> + * struct cros_feature_to_name - CrOS feature id to name/short description.
> * @id: The feature identifier.
> * @name: Device name associated with the feature id.
> * @desc: Short name that will be displayed.
> @@ -36,7 +36,7 @@ struct cros_feature_to_name {
> };
>
> /**
> - * cros_feature_to_cells - CrOS feature id to mfd cells association.
> + * struct cros_feature_to_cells - CrOS feature id to mfd cells association.
> * @id: The feature identifier.
> * @mfd_cells: Pointer to the array of mfd cells that needs to be added.
> * @num_cells: Number of mfd cells into the array.
>