Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

From: Daniel Vetter
Date: Thu Jun 25 2020 - 03:53:45 EST


On Wed, Jun 24, 2020 at 03:08:22PM +0000, Yannick FERTRE wrote:
> Hello Angelo,
> thank for patch.
>
> Reviewed-by: Yannick Fertre <yannick.fertre@xxxxxx>

Patch applied, thanks.
-Daniel

>
>
>
> On 4/3/20 3:30 PM, Angelo Ribeiro wrote:
> > dw-mipi-dsi does not use any definition from drm_probe_helper.
> >
> > Coverity output:
> > Event unnecessary_header:
> > Including .../include/drm/drm_probe_helper.h does not provide any
> > needed symbols.
> >
> > Cc: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
> > Cc: Joao Pinto <jpinto@xxxxxxxxxxxx>
> > Cc: Jose Abreu <jose.abreu@xxxxxxxxxxxx>
> > Signed-off-by: Angelo Ribeiro <angelo.ribeiro@xxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > index 024acad..582635d 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > @@ -27,7 +27,6 @@
> > #include <drm/drm_modes.h>
> > #include <drm/drm_of.h>
> > #include <drm/drm_print.h>
> > -#include <drm/drm_probe_helper.h>
> >
> > #define HWVER_131 0x31333100 /* IP version 1.31 */
> >
> >

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch