Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

From: David Miller
Date: Thu Jun 25 2020 - 01:05:03 EST


From: Po Liu <po.liu@xxxxxxx>
Date: Wed, 24 Jun 2020 17:36:31 +0800

> From: Po Liu <Po.Liu@xxxxxxx>
>
> Flow metering entries in IEEE 802.1Qci is an optional function for a
> flow filtering module. Flow metering is two rates two buckets and three
> color marker to policing the frames. This patch only enable one rate one
> bucket and in color blind mode. Flow metering instance are as
> specified in the algorithm in MEF 10.3 and in Bandwidth Profile
> Parameters. They are:
>
> a) Flow meter instance identifier. An integer value identifying the flow
> meter instance. The patch use the police 'index' as thin value.
> b) Committed Information Rate (CIR), in bits per second. This patch use
> the 'rate_bytes_ps' represent this value.
> c) Committed Burst Size (CBS), in octets. This patch use the 'burst'
> represent this value.
> d) Excess Information Rate (EIR), in bits per second.
> e) Excess Burst Size per Bandwidth Profile Flow (EBS), in octets.
> And plus some other parameters. This patch set EIR/EBS default disable
> and color blind mode.
>
> v1->v2 changes:
> - Use div_u64() as division replace the '/' report:
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> All errors (new ones prefixed by >>):
>
> ld: drivers/net/ethernet/freescale/enetc/enetc_qos.o: in function `enetc_flowmeter_hw_set':
>>> enetc_qos.c:(.text+0x66): undefined reference to `__udivdi3'
>
>
> Signed-off-by: Po Liu <Po.Liu@xxxxxxx>

Applied.