Re: [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.

[Paul Cercueil]

Hi João,

Le mar. 23 juin 2020 à 18:19, João H. Spies <jhlspies@xxxxxxxxx> a 
écrit :
> Previously marked as active high, but is in reality active low.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
> Signed-off-by: João H. Spies <jhlspies@xxxxxxxxx>

Good catch.

Tested-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts 
> b/arch/mips/boot/dts/ingenic/gcw0.dts
> index 8d22828787d8..bc72304a2440 100644
> --- a/arch/mips/boot/dts/ingenic/gcw0.dts
> +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
> @@ -92,7 +92,7 @@
>  			"MIC1N", "Built-in Mic";
>  		simple-audio-card,pin-switches = "Speaker", "Headphones";
>
> -		simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>;
> +		simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>;
>  		simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>;
>
>  		simple-audio-card,bitclock-master = <&dai_codec>;
> --
> 2.17.1