Re: [PATCH 1/7] irqchip: Fix potential resource leaks

From: Krzysztof Kozlowski
Date: Wed Jun 24 2020 - 05:15:37 EST


On Tue, 23 Jun 2020 at 10:51, Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:
>
> There exists some potential resource leaks in the error path, fix them.

This should be split per driver and per bug (although mostly in driver
it's just one bug). Otherwise it is difficult to review, backport and
revert.

Best regards,
Krzysztof


> Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> ---
> drivers/irqchip/irq-ath79-misc.c | 3 +++
> drivers/irqchip/irq-csky-apb-intc.c | 3 +++
> drivers/irqchip/irq-csky-mpintc.c | 26 ++++++++++++++++++++------
> drivers/irqchip/irq-davinci-aintc.c | 17 +++++++++++++----
> drivers/irqchip/irq-davinci-cp-intc.c | 17 ++++++++++++++---
> drivers/irqchip/irq-digicolor.c | 4 ++++
> drivers/irqchip/irq-dw-apb-ictl.c | 11 ++++++++---
> drivers/irqchip/irq-loongson-htvec.c | 5 ++++-
> drivers/irqchip/irq-ls1x.c | 4 +++-
> drivers/irqchip/irq-mscc-ocelot.c | 6 ++++--
> drivers/irqchip/irq-nvic.c | 2 ++
> drivers/irqchip/irq-omap-intc.c | 4 +++-
> drivers/irqchip/irq-riscv-intc.c | 1 +
> drivers/irqchip/irq-s3c24xx.c | 20 +++++++++++++++-----
> drivers/irqchip/irq-xilinx-intc.c | 1 +
> 15 files changed, 98 insertions(+), 26 deletions(-)