Re: [PATCH v11 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure.

From: Jarkko Sakkinen
Date: Mon Jun 22 2020 - 17:59:36 EST


On Thu, Jun 18, 2020 at 04:43:38PM +0300, amirmizi6@xxxxxxxxx wrote:
> From: Amir Mizinski <amirmizi6@xxxxxxxxx>
>
> Added a retry mechanism on any protocol error. In addition, a retry is
> added in case of a data integrity issue in the I2C bus protocol. The check
> is performed after sending a command to the TPM and after receiving a
> response from the TPM.

No chance to merge this without reasoning why on any protocol error we
should retry. It's not reasoned here. Unfotunately, with this premise I
cannot merge this.

/Jarkko