Re: [PATCH] Revert "kernel/printk: add kmsg SEEK_CUR handling"

From: Bruno Meneguele
Date: Mon Jun 22 2020 - 13:37:53 EST


On Mon, Jun 22, 2020 at 10:32:51AM -0700, Linus Torvalds wrote:
> On Mon, Jun 22, 2020 at 10:10 AM Bruno Meneguele <bmeneg@xxxxxxxxxx> wrote:
> >
> > Although both options are pretty fine by me too, I "fear" (not really)
> > we can end up stacking special behavior interfaces, forcing userspace to
> > keep a "table of special case files". Personally, I prefer to return
> > something _valid_ to userspace rather than _fail_ with special meaning.
>
> Well, what's even worse if user space has to handle two different
> things just because behavior changed in different kernels..
>
> So at some point "odd behavior" is much better than "odd behavior in
> two different ways"..

Really well pointed!

Ok, +1 for doc-only patch it is :).

--
bmeneg
PGP Key: http://bmeneg.com/pubkey.txt

Attachment: signature.asc
Description: PGP signature