Re: [RFT][PATCH v2 2/4] ACPI: OSL: Add support for deferred unmapping of ACPI memory

From: Andy Shevchenko
Date: Mon Jun 22 2020 - 11:47:11 EST


On Mon, Jun 22, 2020 at 6:28 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> On Mon, Jun 22, 2020 at 4:56 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Jun 22, 2020 at 5:06 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:

...

> > > + return true;
> > > + }
> > > +
> > > + return false;
> >
> > A nit:
> >
> > Effectively it returns a value of defer.
> >
> > return defer;
> >
> > > }
>
> Do you mean that one line of code could be saved? Yes, it could.

Yes. The question here would it make a cleaner way for the reader to
understand the returned value?

(For the rest, nevermind, choose whatever suits better in your opinion)

--
With Best Regards,
Andy Shevchenko